[Bristuff-users] moh fixes in bristuff-0.4.0-RC3c?

[Tzafrir Cohen]

Hi

I'm looking at bristuff 0.4.0-RC3c . The CHANGES file lists:

  - fixed segmentation fault in chan_zap when calling 
    ast_moh_start/ast_moh_stop (ported from 0.3.0-PRE-1y-s to asterisk 
    1.4.21.1)

The only relevant changes I see are to the kernel modules cwain 
(the E1 card) and ztgsm.

$ diff -ur -I '^@@ ' -I '^--- ' -I '^\+\+\+ ' -I '^Index' bristuff-0.4.0-RC3[bc] | diffstat
 CHANGES                                    |    5 +
 cwain/cwain.c                              |   97 +++++++++++++++++++++--------
 cwain/zapata.conf                          |    1
 cwain/zapata.conf.doubleE1                 |    1
 download.sh                                |    8 +-
 patches/asterisk/102-asterisk_version.diff |    4 -
 patches/asterisk/122-chan_zap-GSM.diff     |   55 ++++++++++++++--
 qozap/qozap.c                              |   44 +++++++++++--
 qozap/zapata.conf                          |    1
 qozap/zapata.conf.duoBRI                   |    1
 qozap/zapata.conf.octoBRI                  |    1
 ztgsm/ztgsm.c                              |    2
 12 files changed, 176 insertions(+), 44 deletions(-)

(The changes in 122-chan_zap-GSM.diff are funny: overcomplication instead 
of adding a '<use>gsmat</use>' in the moduleinfo comment of chan_zap.c).

BTW: and speking of silly things in a gsm patch: my gsm patch in latest
bristuff includes a silly typo of its own. And this one actually causes
damage:

index 8bee650..f71adb2 100644
--- a/include/asterisk/dahdi_compat.h
+++ b/include/asterisk/dahdi_compat.h
@@ -27,14 +27,14 @@
 #include <dahdi/user.h>

 #define DAHDI_DIR_NAME "/dev/dahdi"
-#define DAHDI_NAME "Zaptel"
+#define DAHDI_NAME "DAHDI"

 #elif defined(HAVE_ZAPTEL)

 #include <zaptel/zaptel.h>

-#define DAHDI_DIR_NAME "/dev/zaptel"
-#define DAHDI_NAME "DAHDI"
+#define DAHDI_DIR_NAME "/dev/zap"
+#define DAHDI_NAME "Zaptel"

 /* Compiling against Zaptel instead of DAHDI */

If anybody wonders why bristuff asks about /dev/zaptel - that's it. 
Uploading a fix soon.


-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir