[Bristuff-users] what's in bristuff?

[Steve Davies]

re-sending to the list (sorry Tzafrir for the duplicate)

I have found several anomolies like this - I think that several of the
features in bristuff were started, and then code has been commented or
removed (there is some evidence of this dotted through the code) and
un-needed variables have been left in-place.

perhaps 'usercid' is related to the chan_sip code to do COLP, which is
all commented out  - It does not work properly anyway.

I also found that the bristuff code modifies chan_zap so that it tries
to use the TON and NPI fields of a called number to prefix
national/international digits to a called number. Sadly, this is
incorrect in about 99% of cases and the TON and NPI fields are for
"informtion only" - Generally, the received number is truncated by the
network before sending, and prefixing it is meaningless.

The original chan_zap did not do this, and my local build of chan_zap
no-longer does this :)

Ho hum.
Steve


2008/8/7 Tzafrir Cohen <tzafrir.cohen at xorcom.com>:
> One other thing I wonder about:
>
> the patch adds an extra item called "usercid" to struct zt_pri (the
> struct for a PRI span). It is read from the configuration item
> "pritrustusercid", gets into the struct and then ...
>
> never gets used.
>
> Any idea what it is for?
>